-
Notifications
You must be signed in to change notification settings - Fork 619
[Dashboard] Login flow improvements #5658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5658 +/- ##
=======================================
Coverage 50.72% 50.72%
=======================================
Files 1092 1092
Lines 57213 57213
Branches 4630 4630
=======================================
Hits 29019 29019
Misses 27478 27478
Partials 716 716
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
2124905 to
4e8de10
Compare
4e8de10 to
76bdc9f
Compare
Merge activity
|
Fixes: DASH-564 and DASH-494 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the user interface and functionality related to wallet connection across various components in the dashboard, primarily changing instances of "Sign In" to "Connect Wallet" and modifying how account information is handled. ### Detailed summary - Changed button text from `Sign In` to `Connect Wallet` in multiple components. - Updated `TeamHeader` to use `getRawAccount` instead of `getAuthToken`. - Modified account handling in `TeamLayout` functions to include `getValidAccount`. - Adjusted `LoginPage` logic for account onboarding and redirection. - Enhanced `TeamHeaderLoggedIn` to accept `account` as a prop directly. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
76bdc9f to
3268af6
Compare

Fixes: DASH-564 and DASH-494
PR-Codex overview
This PR focuses on changing the UI text from "Sign In" to "Connect Wallet" across various components in the dashboard application, enhancing clarity for users regarding wallet connection actions. Additionally, it updates account retrieval methods and logic in several components.
Detailed summary
Sign IntoConnect Walletin multiple components:MismatchButtonFaucetButtonTeamHeaderLoggedOutTeamHeaderLoggedOutMobileUIgetAuthTokentogetRawAccountinTeamHeader.TeamLayoutto fetch account details usinggetValidAccount.LoginPageto ensure redirects are handled correctly based on account status.TeamHeaderLoggedInto pass account information directly.